Skip to content

perf(Algebra/Ring/Defs): unfold the new Semiring instances#39772

Closed
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-Semiring-instances-2
Closed

perf(Algebra/Ring/Defs): unfold the new Semiring instances#39772
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-Semiring-instances-2

Conversation

@JovanGerb

Copy link
Copy Markdown
Contributor

I really hope that this ugly thing does not give a speedup.


Open in Gitpod

@JovanGerb

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

leanprover-radar commented May 24, 2026

Copy link
Copy Markdown

Benchmark results for 650d4a8 against 88330eb are in. No significant results found. @JovanGerb

  • 🟥 build//instructions: +101.3G (+0.06%)

Medium changes (1🟥)

  • 🟥 build/module/Mathlib.RingTheory.LaurentSeries//instructions: +21.9G (+10.57%)

Small changes (1✅, 6🟥)

  • 🟥 build/module/Mathlib.Algebra.EuclideanDomain.Field//instructions: +248.9M (+4.43%)
  • 🟥 build/module/Mathlib.Algebra.Order.Ring.Idempotent//instructions: +212.6M (+1.55%)
  • 🟥 build/module/Mathlib.Analysis.Meromorphic.Divisor//instructions: +783.8M (+2.59%)
  • 🟥 build/module/Mathlib.Analysis.Meromorphic.Order//instructions: +2.2G (+3.43%)
  • build/module/Mathlib.Computability.AkraBazzi.SumTransform//instructions: -1.9G (-2.36%)
  • 🟥 build/module/Mathlib.Lean.Elab.InfoTree//instructions: +87.2M (+3.71%)
  • 🟥 build/module/Mathlib.RingTheory.AdicCompletion.Completeness//instructions: +4.1G (+8.52%)

@github-actions

Copy link
Copy Markdown

PR summary 650d4a8cd0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance [i : Semiring α] : Distrib α
+ instance [i : Semiring α] : MulZeroClass α
+ instance [i : Semiring α] : MulZeroOneClass α
- instance [Semiring α] : Distrib α := inferInstance
- instance [Semiring α] : MulZeroClass α := inferInstance
- instance [Semiring α] : MulZeroOneClass α := inferInstance

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label May 24, 2026
@JovanGerb JovanGerb closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants